hubble: Add reserved-identity metric context #20474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
michi-covalent
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
michi-covalent
force-pushed
the
pr/michi/reserved-identity-context
branch
2 times, most recently
from
4b7c469
to
91f7252
Compare
Allow Hubble metrics to use reserved labels as contexts. There are some
cases where the identity context is too noisy for reserved entities.
1. kube-apiserver
Depending on where the Kubernetes API server is running, the identity
context shows up as something like this:
cidr:1.2.3.4/32,reserved:kube-apiserver,reserved:world
The reserved-identity context returns reserved:kube-apiserver in this
case.
2. CIDR identities
For CIDR identities, the identity context shows up as something like:
cidr:1.2.3.4/32,reserved:world
The reserved-identity context returns reserved:world in this case.
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/reserved-identity-context
branch
from
91f7252
to
2c6d9c6
Compare
|
/test |
|
ignoring gke failure. marking as ready to merge |
michi-covalent
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Hubble metrics to use reserved labels as contexts. There are some
cases where the identity context is too noisy for reserved entities.
kube-apiserver
Depending on where the Kubernetes API server is running, the identity
context shows up as something like this:
The reserved-identity context returns reserved:kube-apiserver in this
case.
CIDR identities
For CIDR identities, the identity context shows up as something like:
The reserved-identity context returns reserved:world in this case.
Signed-off-by: Michi Mutsuzaki michi@isovalent.com