Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference datapath metrics in feature and troubleshooting guides #20520

Merged
merged 2 commits into from Sep 28, 2022
Merged

Reference datapath metrics in feature and troubleshooting guides #20520

merged 2 commits into from Sep 28, 2022

Conversation

aditighag
Copy link
Member

@aditighag aditighag commented Jul 13, 2022 •
edited

See commits description.

@aditighag aditighag added the release-note/misc This PR makes changes that have no direct user impact. label Jul 13, 2022
@aditighag aditighag requested a review from a team July 13, 2022 23:57
@aditighag aditighag requested a review from a team as a code owner July 13, 2022 23:57
@aditighag aditighag marked this pull request as draft July 13, 2022 23:57
@aditighag aditighag force-pushed the pr/aditighag/reference-datapath-metrics branch from 058590c to ad83ea2 Compare July 14, 2022 00:39
@aditighag aditighag marked this pull request as ready for review July 14, 2022 00:40
@aditighag aditighag marked this pull request as draft July 14, 2022 03:30
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.12.0 Jul 15, 2022
@aanm aanm added this to Needs backport from master in 1.12.1 Jul 19, 2022
@aanm aanm removed this from Needs backport from master in 1.12.0 Jul 19, 2022
@joestringer joestringer added this to Needs backport from master in 1.12.2 Aug 15, 2022
@joestringer joestringer removed this from Needs backport from master in 1.12.1 Aug 15, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Aug 27, 2022
@aditighag aditighag removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Aug 27, 2022
@nebril nebril added this to Needs backport from master in 1.12.3 Sep 14, 2022
@nebril nebril removed this from Needs backport from master in 1.12.2 Sep 14, 2022
@aditighag aditighag marked this pull request as ready for review September 23, 2022 15:28
@aditighag
docs: Reference terminating endpoints metric in kube-proxy free guide
78f9615 
The graceful termination feature relies on receiving
terminating endpoint events from Kubernetes, which are gated
by a flag. Reference the terminating endpoint metric in the
feature section so that users can track the metric to check
if the feature is working correctly, as a first step.

Signed-off-by: Aditi Ghag <aditi@cilium.io>
@aditighag
docs: Reference conntrack metrics in troubleshooting guide
167c768 
The troubleshooting guide explains packet drops seen due to
conntrack map fill-up issue. Reference some of the conntrack
garbage collection related metrics so that users get visibility
into conntrack gc runs - how often it's being triggered, how many
entries were gc'd, etc.

Signed-off-by: Aditi Ghag <aditi@cilium.io>
@aditighag aditighag force-pushed the pr/aditighag/reference-datapath-metrics branch from ad83ea2 to 167c768 Compare September 23, 2022 15:29
@aditighag aditighag requested a review from a team as a code owner September 23, 2022 15:29
@aditighag
Copy link
Member Author

Rebased the PR.

qmonnet
qmonnet approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good

@borkmann borkmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 28, 2022
@gandro gandro merged commit 18ef607 into cilium:master Sep 28, 2022
@ldelossa ldelossa mentioned this pull request Oct 6, 2022
Closed
@sayboras sayboras mentioned this pull request Oct 8, 2022
Merged
8 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.12 in 1.12.3 Oct 8, 2022
@sayboras sayboras added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Oct 10, 2022
@qmonnet qmonnet moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.3 Oct 12, 2022
@qmonnet qmonnet mentioned this pull request Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.12.3
Backport done to v1.12
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aditighag @borkmann @qmonnet @gandro @sayboras