docs(masquerading): add missing "address" #20538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raphaël Pinson <raphael@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
Signed-off-by: Raphaël Pinson <raphael@isovalent.com>
qmonnet
approved these changes
Jul 15, 2022
| (to an output device IPv4 address), if the output device runs the program. If not | ||
| specified, the program will be automatically attached to the devices selected by | ||
| :ref:`the BPF NodePort device detection metchanism <Nodeport Devices>`. | ||
| program. This means that a packet sent from a pod to an outside address will be |
There was a problem hiding this comment.
I'd have thought “to the outside...” instead, but it works too with “address”.
qmonnet
added
area/documentation
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
qmonnet
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.12
in 1.12.0
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.12
in 1.12.0
ldelossa
added
backport-done/1.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.0
tklauser
added
backport-done/1.11
tklauser
moved this from Needs backport from master
to Backport done to v1.11
in 1.11.8
tklauser
moved this from Needs backport from master
to Backport done to v1.10
in 1.10.14
This was referenced Aug 11, 2022
|
This is still marked as backport-1.9, is that accurate? |
|
No I think it no longer qualifies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raphaël Pinson raphael@isovalent.com