pkg/k8s: do not wait for endpointslice cache sync in k8s >= 1.17 #20569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stopping the EndpointSlice Kubernetes watchers we should also cancel the waiting to sync this group resource. In failing doing it so, Cilium will timeout on waiting for these resources on Kubernetes versions that should have EndpointSlice v1beta1 available but it's not enabled. Fixes: a0c1ad6 ("pkg/k8s/version: Set EndpointSlice cap when version >=1.17") Signed-off-by: André Martins <andre@cilium.io>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
/test-1.17-4.9 |
aanm
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test Job 'Cilium-PR-K8s-GKE' hit: #17617 (95.01% similarity) |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.12
in 1.12.0
aanm
added
backport-done/1.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.0
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.14
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.11.8
tklauser
added
backport-done/1.11
This was referenced Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stopping the EndpointSlice Kubernetes watchers we should also
cancel the waiting to sync this group resource. In failing doing it so,
Cilium will timeout on waiting for these resources on Kubernetes
versions that should have EndpointSlice v1beta1 available but it's not
enabled.
Fixes: a0c1ad6 ("pkg/k8s/version: Set EndpointSlice cap when version >=1.17")
Signed-off-by: André Martins andre@cilium.io