Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update etcd kvstore migration instructions #20624

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

hhoover
Copy link
Contributor

@hhoover hhoover commented Jul 21, 2022

The Helm chart does not have a "global" section for etcd.
This also updates the pod name to cilium-preflight-check-1234
and adds a way to confirm a successful migration.

Signed-off-by: hhoover hart@isovalent.com

The Helm chart does not have a "global" section for etcd.
This also updates the pod name to cilium-preflight-check-1234
and adds a way to confirm a successful migration.

Signed-off-by: hhoover <hart@isovalent.com>
@hhoover hhoover requested a review from a team as a code owner July 21, 2022 15:21
@hhoover hhoover requested a review from joestringer July 21, 2022 15:21
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 21, 2022
@tklauser tklauser added release-note/misc This PR makes changes that have no direct user impact. sig/kvstore Impacts the KVStore package interactions. labels Jul 21, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 21, 2022
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.14 Jul 21, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.8 Jul 21, 2022
@joestringer joestringer merged commit 2778eb5 into cilium:master Jul 21, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.14 Aug 9, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.8 Aug 9, 2022
@tklauser tklauser added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.10 and removed backport-pending/1.11 labels Aug 11, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.8 Aug 11, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.14 Aug 11, 2022
@tklauser tklauser added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact. sig/kvstore Impacts the KVStore package interactions.
Projects
No open projects
1.10.14
Backport done to v1.10
1.11.8
Backport done to v1.11
Development

Successfully merging this pull request may close these issues.

None yet

5 participants