Add support to fallback from ENI PD if subnet is out of /28 prefixes #20822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
hemanthmalla
force-pushed
the
hemanthmalla/pd_fallback
branch
from
014f62f
to
2ae9cbe
Compare
hemanthmalla
requested review from
christarazi and
gandro
and removed request for
christarazi
hemanthmalla
force-pushed
the
hemanthmalla/pd_fallback
branch
from
2ae9cbe
to
1d8cdd8
Compare
hemanthmalla
added
area/eni
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
christarazi
approved these changes
Aug 10, 2022
hemanthmalla
force-pushed
the
hemanthmalla/pd_fallback
branch
2 times, most recently
from
cf00cf4
to
3297552
Compare
gandro
approved these changes
Aug 24, 2022
|
/test Job 'Cilium-PR-K8s-1.24-kernel-net-next' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
christarazi
approved these changes
Aug 30, 2022
hemanthmalla
force-pushed
the
hemanthmalla/pd_fallback
branch
from
3297552
to
da0237f
Compare
aanm
approved these changes
Sep 1, 2022
|
@hemanthmalla Could you rebase the PR? I believe some of the build failures were already fixed in master branch. |
hemanthmalla
force-pushed
the
hemanthmalla/pd_fallback
branch
from
da0237f
to
d73cf4b
Compare
|
@aanm build seems to have failed again ? |
|
Yep looks like a known failure: #21145 |
|
/test Job 'Cilium-PR-K8s-1.16-kernel-4.9' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
|
Rebasing again to include changes from #21220 |
When a subnet is very fragmented, there might not be enough free contiguous IPs to make up a /28 block. Without this fallback, new node creation would be blocked when PD is enabled and subnet is in this state. Currently operator does not support PD in mixed mode. Once a node has secondary IP addresses attached on the ENI, operator will not attempt to allocate any more prefixes. Signed-off-by: Hemanth Malla <hemanth.malla@datadoghq.com>
hemanthmalla
force-pushed
the
hemanthmalla/pd_fallback
branch
from
d73cf4b
to
09512fa
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a subnet is very fragmented, there might not be enough free
contiguous IPs to make up a
/28block. Without this fallback, new nodecreation would be blocked when PD is enabled and subnet is in this
state. Currently operator does not support PD in mixed mode. Once a node
has secondary IP addresses attached on the ENI, operator will not attempt
to allocate any more prefixes.
With this fallback, operator will try to provision new nodes with prefix delegation
enabled. If a subnet doesn't have
/28blocks available, regular/32IPs wouldbe allocated instead.
AWS VPC CNI plugin uses
v1ofaws-sdk-goand has better error handling.Out of capacity errors are logged in VPC CNI plugin, but it does not seem to have
any fallback.