-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for k8s 1.25.0 #20995
add support for k8s 1.25.0 #20995
Conversation
01d5bdc
to
2b13f12
Compare
/test-1.25-net-next |
/test-k8s-upstream |
/test-upstream-k8s |
2b13f12
to
0d3366e
Compare
/test-k8s-upstream |
/test-1.25-net-next |
4f08f84
to
8a9cb26
Compare
8a9cb26
to
0dc5344
Compare
/test-1.25-net-next |
1 similar comment
/test-1.25-net-next |
0dc5344
to
02e176a
Compare
/test-1.25-net-next |
02e176a
to
a261563
Compare
/test-1.25-net-next |
a261563
to
fc6151a
Compare
/test-1.25-net-next |
fc6151a
to
6534923
Compare
/test-1.25-net-next |
6534923
to
60da0d4
Compare
/test-1.25-net-next |
/test-upstream-k8s |
/test |
3b4912a
to
386e8ec
Compare
/test-1.25-net-next |
/test-upstream-k8s |
/test |
We have dropped the requirement for the kubernetes-cni version because that is already defined as a requirement for the kubeadm package. Signed-off-by: André Martins <andre@cilium.io>
386e8ec
to
f522295
Compare
/test-upstream-k8s |
This test is currently failing and will be skipped until #21060 is fixed. Signed-off-by: André Martins <andre@cilium.io>
f522295
to
639a8b8
Compare
/test-upstream-k8s |
/test Job 'Cilium-PR-K8s-1.24-kernel-net-next' failed: Click to show.Test Name
Failure Output
If it is a flake and a GitHub issue doesn't already exist to track it, comment |
/test-1.24-net-next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
For other reviewer, IngressClass is removed from slim objects, as we are creating Cilium IngressClass as part of helm instead.
@@ -0,0 +1,16 @@ | |||
apiVersion: discovery.k8s.io/v1beta1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK EndpointSlice becomes stable in 1.21, any reason we are still using v1beta1 here?
https://kubernetes.io/docs/concepts/services-networking/endpoint-slices/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
Signed-off-by: André Martins andre@cilium.io
TODO: needs an update in the control-plane tests. Will be done as a follow up