Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for k8s 1.25.0 #20995

Merged
merged 2 commits into from
Aug 26, 2022
Merged

add support for k8s 1.25.0 #20995

merged 2 commits into from
Aug 26, 2022

Conversation

aanm
Copy link
Member

@aanm aanm commented Aug 19, 2022

Signed-off-by: André Martins andre@cilium.io

TODO: needs an update in the control-plane tests. Will be done as a follow up

@aanm aanm added the release-note/major This PR introduces major new functionality to Cilium. label Aug 19, 2022
@aanm aanm force-pushed the pr/add-support-k8s-1.25 branch 3 times, most recently from 01d5bdc to 2b13f12 Compare August 19, 2022 20:27
@nbusseneau
Copy link
Member

/test-1.25-net-next

@aanm
Copy link
Member Author

aanm commented Aug 22, 2022

/test-k8s-upstream

@aanm
Copy link
Member Author

aanm commented Aug 22, 2022

/test-upstream-k8s

@aanm
Copy link
Member Author

aanm commented Aug 22, 2022

/test-k8s-upstream

@aanm
Copy link
Member Author

aanm commented Aug 22, 2022

/test-1.25-net-next

@aanm aanm force-pushed the pr/add-support-k8s-1.25 branch 2 times, most recently from 4f08f84 to 8a9cb26 Compare August 24, 2022 09:38
@aanm aanm changed the title add support for k8s 1.25.0-rc.1 add support for k8s 1.25.0 Aug 24, 2022
@aanm
Copy link
Member Author

aanm commented Aug 24, 2022

/test-1.25-net-next

1 similar comment
@aanm
Copy link
Member Author

aanm commented Aug 24, 2022

/test-1.25-net-next

@aanm
Copy link
Member Author

aanm commented Aug 24, 2022

/test-1.25-net-next

@aanm
Copy link
Member Author

aanm commented Aug 24, 2022

/test-1.25-net-next

@aanm
Copy link
Member Author

aanm commented Aug 24, 2022

/test-1.25-net-next

@aanm
Copy link
Member Author

aanm commented Aug 24, 2022

/test-1.25-net-next

@aanm
Copy link
Member Author

aanm commented Aug 24, 2022

/test-1.25-net-next

@aanm
Copy link
Member Author

aanm commented Aug 24, 2022

/test-upstream-k8s

@aanm
Copy link
Member Author

aanm commented Aug 24, 2022

/test

@aanm aanm force-pushed the pr/add-support-k8s-1.25 branch 2 times, most recently from 3b4912a to 386e8ec Compare August 25, 2022 10:41
@aanm
Copy link
Member Author

aanm commented Aug 25, 2022

/test-1.25-net-next

@aanm
Copy link
Member Author

aanm commented Aug 25, 2022

/test-upstream-k8s

@aanm
Copy link
Member Author

aanm commented Aug 25, 2022

/test

We have dropped the requirement for the kubernetes-cni version because
that is already defined as a requirement for the kubeadm package.

Signed-off-by: André Martins <andre@cilium.io>
@aanm
Copy link
Member Author

aanm commented Aug 25, 2022

/test-upstream-k8s

This test is currently failing and will be skipped until
#21060 is fixed.

Signed-off-by: André Martins <andre@cilium.io>
@aanm
Copy link
Member Author

aanm commented Aug 25, 2022

/test-upstream-k8s

@aanm
Copy link
Member Author

aanm commented Aug 25, 2022

/test

Job 'Cilium-PR-K8s-1.24-kernel-net-next' failed:

Click to show.

Test Name

K8sDatapathConfig Check BPF masquerading with ip-masq-agent DirectRouting

Failure Output

FAIL: Failed to add ip route

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.24-kernel-net-next so I can create one.

@aanm aanm marked this pull request as ready for review August 25, 2022 18:36
@aanm aanm requested review from a team as code owners August 25, 2022 18:36
@aanm aanm requested review from rolinh, tklauser, nathanjsweet, qmonnet and sayboras and removed request for nathanjsweet August 25, 2022 18:36
@aanm aanm added the sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. label Aug 25, 2022
@aanm
Copy link
Member Author

aanm commented Aug 25, 2022

/test-1.24-net-next

Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

For other reviewer, IngressClass is removed from slim objects, as we are creating Cilium IngressClass as part of helm instead.

@@ -0,0 +1,16 @@
apiVersion: discovery.k8s.io/v1beta1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK EndpointSlice becomes stable in 1.21, any reason we are still using v1beta1 here?

https://kubernetes.io/docs/concepts/services-networking/endpoint-slices/

Copy link
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@aanm aanm merged commit f111563 into master Aug 26, 2022
@aanm aanm deleted the pr/add-support-k8s-1.25 branch August 26, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/major This PR introduces major new functionality to Cilium. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants