docs: Update ToServices docs section #21052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
needs-backport/1.11
release-note/misc
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
tklauser
reviewed
Aug 24, 2022
qmonnet
approved these changes
Aug 24, 2022
Update this section to highlight the limitation, improve wording, and remove future-looking statements. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
submit/to-services-port
branch
from
b16a58f
to
a74763b
Compare
tklauser
approved these changes
Aug 25, 2022
qmonnet
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.12
in 1.12.2
This was referenced Aug 29, 2022
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.11.9
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.15
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.15
aanm
added
backport-done/1.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.2
aanm
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.11
in 1.11.9
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.11
in 1.11.9
This was referenced Sep 14, 2022
atykhyy
added a commit
to Apptane/cilium
that referenced
this pull request
Jun 23, 2023
PR cilium#21052 updated Cilium documentation to say that, in network policy rules, `toServices` statements cannot be combined with `toPorts` statements. I believe it would be more informative for Cilium users to say (following RFC 2119) that `toServices` _must not_ be combined with `toPorts`, as technically Cilium accepts such a network policy as valid but handles it in the unexpected and potentially dangerous (e.g. if a setup relies on Cilium network policy to implement egress filtering) manner described in cilium#20067. Signed-off-by: Anton Tykhyy <atykhyy@gmail.com>
ldelossa
pushed a commit
that referenced
this pull request
Jun 26, 2023
PR #21052 updated Cilium documentation to say that, in network policy rules, `toServices` statements cannot be combined with `toPorts` statements. I believe it would be more informative for Cilium users to say (following RFC 2119) that `toServices` _must not_ be combined with `toPorts`, as technically Cilium accepts such a network policy as valid but handles it in the unexpected and potentially dangerous (e.g. if a setup relies on Cilium network policy to implement egress filtering) manner described in #20067. Signed-off-by: Anton Tykhyy <atykhyy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update this section to highlight the limitation, improve wording, and
remove future-looking statements.