Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vagrant: Bump 4.9 Vagrant box (Linux 4.9.326, to fix a kernel bug) #21106

Merged
merged 1 commit into from Aug 26, 2022

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented Aug 26, 2022

We have been hitting a kernel bug on 4.9 for the verifier tests. An underflow on the memlock rlimit counter, caused by the reallocation of BPF programs not updating the charged values, makes the counter go under zero and convert into a huge value, blocking all further loads of BPF objects.

This has been fixed in kernel 4.10, and was backported at last in 4.9.326. We generated a new Ubuntu image based on that, let's update.

Fixes: #20288

@qmonnet qmonnet added area/CI Continuous Integration testing issue or flake sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/ci This PR makes changes to the CI. labels Aug 26, 2022
We have been hitting a kernel bug on 4.9 for the verifier tests. An
underflow on the memlock rlimit counter, caused by the reallocation of
BPF programs not updating the charged values, makes the counter go under
zero and convert into a huge value, blocking all further loads of BPF
objects [0].

This has been fixed in kernel 4.10 [1], and was backported at last in
4.9.326. We generated a new Ubuntu image based on that, let's update.

[0] cilium#20288
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=5ccb071e97fbd9ffe623a0d3977cc6d013bee93c

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@qmonnet
Copy link
Member Author

qmonnet commented Aug 26, 2022

/test-1.16-4.9

@qmonnet qmonnet marked this pull request as ready for review August 26, 2022 15:31
@qmonnet qmonnet requested a review from a team as a code owner August 26, 2022 15:31
@qmonnet qmonnet requested a review from tklauser August 26, 2022 15:31
@qmonnet qmonnet added the priority/high This is considered vital to an upcoming release. label Aug 26, 2022
@qmonnet
Copy link
Member Author

qmonnet commented Aug 26, 2022

k8s-1.16-kernel-4.9 passed successfully

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. priority/high This is considered vital to an upcoming release. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
5 participants