Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hubble-ui: release v0.9.2 #21127

Merged
merged 1 commit into from
Sep 1, 2022
Merged

hubble-ui: release v0.9.2 #21127

merged 1 commit into from
Sep 1, 2022

Conversation

geakstr
Copy link
Contributor

@geakstr geakstr commented Aug 30, 2022

Signed-off-by: Dmitry Kharitonov dmitry@isovalent.com

Added `hubble.ui.frontend.server.ipv6.enabled` helm flag to control nginx server ipv6 listener

@geakstr geakstr self-assigned this Aug 30, 2022
@geakstr geakstr requested review from a team as code owners August 30, 2022 10:55
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 30, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.9 Aug 30, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.12.2 Aug 30, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.15 Aug 30, 2022
@rolinh rolinh added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Aug 30, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 30, 2022
@@ -1,7 +1,9 @@
{{- define "hubble-ui.nginx.conf" }}
server {
listen 8081;
{{- if .Values.hubble.ui.frontend.server.ipv6.enabled }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious if there is any issue having dual stack enabled by default 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's better to make it disabled by default? That would be a change that potentially can break some current deployments I think.

Added `hubble.ui.frontend.server.ipv6.enabled` helm flag to control
nginx server ipv6 listener

Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com>
@aanm aanm merged commit c3feb60 into master Sep 1, 2022
@aanm aanm deleted the pr/dima/hubble-ui-v0.9.2 branch September 1, 2022 14:01
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.15 Sep 7, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.9 Sep 7, 2022
@christarazi christarazi added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Sep 12, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.12 in 1.12.2 Sep 12, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.12 in 1.12.2 Sep 12, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.15 Sep 13, 2022
@nebril nebril added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Sep 13, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.9 Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.10.15
Backport done to v1.10
1.11.9
Backport done to v1.11
1.12.2
Backport done to v1.12
Development

Successfully merging this pull request may close these issues.

None yet

10 participants