-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hubble/filter: add a new endpoint workload filter #21296
hubble/filter: add a new endpoint workload filter #21296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, thanks!
15e3f18
to
0a587b2
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment.
bec620e
to
b131be4
Compare
7197f10
to
626c279
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, lgtm!
6feb30a
to
e796431
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A very minor nit in the test cases, otherwise looks good to me!
e796431
to
573fb9f
Compare
/test Job 'Cilium-PR-K8s-1.25-kernel-net-next' failed: Click to show.Test Name
Failure Output
If it is a flake and a GitHub issue doesn't already exist to track it, comment |
739f163
to
bb5d3e4
Compare
bb5d3e4
to
22552f5
Compare
Before this patch, although the source and destination endpoint workload information was filled in Hubble flows, the GetFlows API did not expose a way to filter on the workload fields. This commit add server-side support for filtering flows based on source and/or destination endpoint workloads. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
/test Job 'Cilium-PR-K8s-1.25-kernel-net-next' failed: Click to show.Test Name
Failure Output
If it is a flake and a GitHub issue doesn't already exist to track it, comment |
/ci-external-workloads |
/test-1.25-net-next |
@chancez won't be able to review this, CI passed and all other reviews are in so marking as |
This adds support to Hubble CLI for filtering against endpoints workloads The server side of this was implemented in cilium/cilium#21296 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
This adds support to Hubble CLI for filtering against endpoints workloads The server side of this was implemented in cilium/cilium#21296 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
This adds support to Hubble CLI for filtering against endpoints workloads The server side of this was implemented in cilium/cilium#21296 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
This adds support to Hubble CLI for filtering against endpoints workloads The server side of this was implemented in cilium/cilium#21296 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
This adds support to Hubble CLI for filtering against endpoints workloads The server side of this was implemented in cilium/cilium#21296 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
This adds support to Hubble CLI for filtering against endpoints workloads The server side of this was implemented in cilium/cilium#21296 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
This adds support to Hubble CLI for filtering against endpoints workloads The server side of this was implemented in cilium/cilium#21296 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
This adds support to Hubble CLI for filtering against endpoints workloads The server side of this was implemented in cilium/cilium#21296 Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
Before this patch, although the source and destination endpoint workload information was filled in Hubble flows, the
GetFlows
API did not expose a way to filter on the workload fields.This commit add server-side support for filtering flows based on source and/or destination endpoint workloads.