sctp: Handle SCTP when correlating Endpoints to services. #21490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
DolceTriade
force-pushed
the
fix-endpoint
branch
from
c8ae112
to
fc508e3
Compare
|
/test Job 'Cilium-PR-K8s-1.25-kernel-net-next' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
sayboras
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
DolceTriade
force-pushed
the
fix-endpoint
branch
from
fc508e3
to
0cc02ff
Compare
Otherwise, Services with SCTP ports and pods with SCTP ports will not have their backends correctly populated. This was missed in the original SCTP PR (b1d9fcd). Signed-off-by: Harsh Modi <harshmodi@google.com>
DolceTriade
force-pushed
the
fix-endpoint
branch
from
0cc02ff
to
ab89ebc
Compare
|
The failure seems unrelated to my change :-/ |
|
@DolceTriade yes, if you search the issues for this test title you can find an issue filed for this already: #21120 |
|
/test |
joestringer
approved these changes
Sep 30, 2022
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, Services with SCTP ports and pods with SCTP ports will not have their backends correctly populated.
This was missed in the original SCTP PR.
Signed-off-by: Harsh Modi harshmodi@google.com