Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD to USERS.md Kilo and Sapian #21503

Merged
merged 1 commit into from
Oct 3, 2022
Merged

ADD to USERS.md Kilo and Sapian #21503

merged 1 commit into from
Oct 3, 2022

Conversation

arpagon
Copy link
Contributor

@arpagon arpagon commented Sep 29, 2022

Developer Certificate of Origin
Signed-off-by: Sebastian Rojo arpagon@gmail.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #issue-number

ADD to USERS.md Kilo and Sapian

@arpagon arpagon requested a review from a team as a code owner September 29, 2022 14:15
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 29, 2022
pchaigno
pchaigno reviewed Sep 29, 2022
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

There seem to be an issue with the second entry below.

USERS.md Show resolved Hide resolved
@pchaigno pchaigno added the release-note/misc This PR makes changes that have no direct user impact. label Sep 29, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 29, 2022
pchaigno
pchaigno requested changes Sep 29, 2022
View reviewed changes
USERS.md Show resolved Hide resolved
arpagon
arpagon commented Sep 29, 2022
View reviewed changes
Copy link
Contributor Author

@arpagon arpagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joestringer and @pchaigno I have already fixed and check booth links. and fix the typo.

joestringer
joestringer requested changes Sep 30, 2022
View reviewed changes
USERS.md Outdated Show resolved Hide resolved
@arpagon @joestringer
ADD to USERS.md Kilo and Sapian
df4ca4d 
Developer Certificate of Origin
Signed-off-by: Sebastian Rojo <arpagon@gmail.com>
Signed-off-by: Joe Stringer <joe@cilium.io>
pchaigno
pchaigno reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squash all commits into one? We should be good to merge after that.

@joestringer joestringer merged commit e95b1e4 into cilium:master Oct 3, 2022
@joestringer
Copy link
Member

I've squashed the commits & merged. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno requested changes

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arpagon @joestringer @pchaigno