fqdn/dnsproxy, daemon: Define new error type for DNS notification #21517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christarazi
added
area/proxy
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
This error is returned when the DNS proxy receives a DNS request for an endpoint that no longer exists to the local daemon. External components which integrate with the DNS proxy code may find it useful to check for this error, hence defining and exporting a type in this package. Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/christarazi/export-ep-fqdn-error
branch
from
eba27fb
to
2c2a278
Compare
christarazi
changed the title
jibi
approved these changes
Sep 30, 2022
aditighag
reviewed
Sep 30, 2022
| @@ -384,6 +384,15 @@ func (e ErrTimedOutAcquireSemaphore) Error() string { | |||
| ) | |||
| } | |||
|
|
|||
| // ErrDNSRequestNoEndpoint represents an error when the local daemon cannot | |||
There was a problem hiding this comment.
when the local daemon cannot
Do you mean the dns proxy?
There was a problem hiding this comment.
Technically, the daemon has the source of truth for endpoints.
joestringer
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error is returned when the DNS proxy receives a DNS request for an
endpoint that no longer exists to the local daemon.
External components which integrate with the DNS proxy code may find it
useful to check for this error, hence defining and exporting a type in
this package.
Signed-off-by: Chris Tarazi chris@isovalent.com