Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon, options: remove deprecated, ineffective options #21524

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

tklauser
Copy link
Member

Remove the disable-conntrack and endpoint-interface-name options which have been deprecated and ineffective since version 1.12.

Remove the `disable-conntrack` and `endpoint-interface-name` options
which have been deprecated and ineffective since version 1.12.

Signed-off-by: Tobias Klauser <tobias@isovalent.com>
@tklauser tklauser added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Sep 30, 2022
@tklauser tklauser requested review from a team as code owners September 30, 2022 10:11
@tklauser
Copy link
Member Author

/test

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 6, 2022
@ldelossa ldelossa merged commit c8fef6f into master Oct 6, 2022
@ldelossa ldelossa deleted the pr/tklauser/options-remove-1.13 branch October 6, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants