Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for release v1.13.0-rc1 #21534

Merged
merged 3 commits into from
Sep 30, 2022
Merged

Prepare for release v1.13.0-rc1 #21534

merged 3 commits into from
Sep 30, 2022

Conversation

joestringer
Copy link
Member

See the included CHANGELOG.md for a full list of changes.

@joestringer
Update AUTHORS and Documentation for v1.13.0-rc1
c6a3b72 
Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer
Prepare for release v1.13.0-rc1
7b40f62 
Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer requested review from a team as code owners September 30, 2022 19:13
@joestringer joestringer added the kind/release Used for a PR that releases a new Cilium version. label Sep 30, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 30, 2022
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Sep 30, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 30, 2022
@joestringer joestringer added dont-merge/preview-only Only for preview or testing, don't merge it. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 30, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 30, 2022
@joestringer joestringer mentioned this pull request Sep 30, 2022
Closed
32 tasks
aditighag
aditighag approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite straight forward. I scanned the changelog for any misclassifications, looks alright to me (especially any missing release notes for bug fixes).

Error: Following files have no owners in CODEOWNERS:
CHANGELOG.md

Should we add the tophat as the owner for this file?

Documentation/network/kubernetes/compatibility-table.rst Show resolved Hide resolved
@joestringer
Copy link
Member Author

joestringer commented Sep 30, 2022 •
edited

Should we add the tophat as the owner for this file?

I'll actually revert that change immediately before release since master branch shouldn't have v1.13.0-rc1 version or its changelog, but that said I like this idea since it'll hide that test failure in future 👍

@joestringer
Revert "Prepare for release v1.13.0-rc1"
b63d97a 
This reverts commit 7b40f62.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer requested a review from a team as a code owner September 30, 2022 19:50
@joestringer joestringer removed the dont-merge/preview-only Only for preview or testing, don't merge it. label Sep 30, 2022
@joestringer
Copy link
Member Author

Ha, we can't win with the github check:

/CHANGELOG.md
Error: The patterns above should be removed from CODEOWNERS.
Error: Process completed with exit code 1.

@joestringer
Copy link
Member Author

The smoke tests passed before and now I've pushed the revert commit according to the release checklist. I'll merge this soon and proceed with the builds.

@joestringer joestringer merged commit 61d7ff0 into cilium:master Sep 30, 2022
@joestringer joestringer deleted the pr/prepare-v1.13.0-rc1 branch September 30, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditighag aditighag aditighag approved these changes

@sayboras sayboras Awaiting requested review from sayboras sayboras was automatically assigned from cilium/sig-k8s

@qmonnet qmonnet Awaiting requested review from qmonnet qmonnet was automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
kind/release Used for a PR that releases a new Cilium version. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joestringer @aditighag