Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/crd: Support master RCs in schema bump script #21535

Merged

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Sep 30, 2022

Add support for release candidates in Documentation/check-crd-compat-table.sh
so that we can remove one more manual step from the release checklist.

@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Sep 30, 2022
@joestringer joestringer requested review from a team as code owners September 30, 2022 19:16
Add support for release candidates in Documentation/check-crd-compat-table.sh
so that we can remove one more manual step from the release checklist.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer force-pushed the submit/support-rc-in-schema-script branch from cf2c4cc to a6db715 Compare September 30, 2022 19:20
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried the script, but the changes look good. Finding the lines by picking an offset of 2 or 4 depending on the case looks a bit fragile, but I don't have a better suggestion.

@sayboras
Copy link
Member

sayboras commented Oct 8, 2022

Seems like required reviews are in, feel free to mark this as ready to merge.

@joestringer joestringer merged commit 48f8135 into cilium:master Oct 11, 2022
@joestringer joestringer deleted the submit/support-rc-in-schema-script branch October 11, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants