Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change slice declarations to array initialization #21536

Merged
merged 1 commit into from
Oct 6, 2022
Merged

change slice declarations to array initialization #21536

merged 1 commit into from
Oct 6, 2022

Conversation

mstrYoda
Copy link
Contributor

@mstrYoda mstrYoda commented Sep 30, 2022 •
edited

Signed-off-by: Emre Savcı emre.savci@trendyol.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

@mstrYoda mstrYoda requested review from a team as code owners September 30, 2022 21:36
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 30, 2022
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Oct 1, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 1, 2022
sayboras
sayboras approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help to trim the commit description to something shorter ? Details can be added in commit message. Please refer to this page for example.

The changes look good to me. Thanks.

@mstrYoda
add array initialization
b78bd2f 
Change slice declarations to array initialization when len is already obvious.
This is a tiny performance improvement.

Signed-off-by: Emre Savcı <emre.savci@trendyol.com>
@mstrYoda
Copy link
Contributor Author

mstrYoda commented Oct 1, 2022

Can you help to trim the commit description to something shorter ? Details can be added in commit message. Please refer to this page for example.

The changes look good to me. Thanks.

I fix the commit message and description 👍

@christarazi christarazi added kind/performance There is a performance impact of this. sig/agent Cilium agent related. labels Oct 3, 2022
@sayboras sayboras changed the title change slice declarations to array initialization when len is already obvious change slice declarations to array initialization Oct 5, 2022
@YutaroHayakawa
Copy link
Member

This is a trivial change, so don't have to test, I think. Making ready to merge.

@YutaroHayakawa YutaroHayakawa added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 6, 2022
@ldelossa ldelossa merged commit cd2ad54 into cilium:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@sayboras sayboras sayboras approved these changes

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

Assignees
No one assigned
Labels
kind/performance There is a performance impact of this. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/agent Cilium agent related.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mstrYoda @YutaroHayakawa @christarazi @sayboras @ldelossa