makefile: add a new target to run 'golangci-lint run --fix' #21547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspsk
added
the
release-note/minor
aspsk
force-pushed
the
aspsk/pr/makefile-add-new-target
branch
from
ae9c2ca
to
357a4ce
Compare
|
/test |
|
/test-ci-datapath |
|
/test-1.25-net-next |
joestringer
reviewed
Oct 5, 2022
aspsk
force-pushed
the
aspsk/pr/makefile-add-new-target
branch
from
a5ba6b3
to
c436103
Compare
|
Commit 58021671cb4ad40f193bb9ba2b02761b944925c1 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
There is a make target to execute the 'golangci-lint run' command, but there is no simple way to execute it with a '--fix' argument. Add a new target to do this. If more arguments need to be added to the golangci-lint command, then one can do this by setting the newly added GOLANGCI_LINT_ARGS variable. Signed-off-by: Anton Protopopov <aspsk@isovalent.com>
The commit 7303c02 ("bpf-mock makefile: Remove removed mock target") removed the bpf-mock-lint target, but there left some comments about running it. Remove the mentions of bpf-mock. Signed-off-by: Anton Protopopov <aspsk@isovalent.com>
aspsk
force-pushed
the
aspsk/pr/makefile-add-new-target
branch
from
5802167
to
8f4c7ec
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
joestringer
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a make target to execute the 'golangci-lint run' command, but there is no simple way to execute it with a '--fix' argument. Add a new target to do this.
If more arguments need to be added to the golangci-lint command, then one can do this by setting the newly added GOLANGCI_LINT_ARGS variable.