hubble: Add "syn-only" option to flows-to-world metric #21571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
added
the
release-note/misc
michi-covalent
force-pushed
the
pr/michi/syn-only
branch
from
b4fc67c
to
aabb253
Compare
|
/test |
michi-covalent
force-pushed
the
pr/michi/syn-only
branch
from
aabb253
to
e9dc28c
Compare
|
/test |
chancez
reviewed
Oct 4, 2022
Use this option to exclude non-SYN drops that could occur transiently from the flows-to-world metric. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Include option flags in Status() output so that these flags show up properly in the log message. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/syn-only
branch
from
e9dc28c
to
f97a287
Compare
|
/test Job 'Cilium-PR-K8s-1.25-kernel-net-next' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
|
|
/test-1.25-net-next |
gandro
approved these changes
Oct 5, 2022
qmonnet
approved these changes
Oct 5, 2022
kaworu
approved these changes
Oct 5, 2022
chancez
approved these changes
Oct 5, 2022
|
not sure why sig-policy team was added to review, this PR only touches hubble metrics. i'm marking it as ready-to-merge. edit: i guess it's because it modifies a file under |
michi-covalent
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits:
syn-onlyoption.Status()method so that it prints option flags. for example:level=info msg="Configured metrics plugin" name=flows-to-world status="syn-only,destination=dns|reserved-identity,source=namespace" subsys=hubble