ci: reenable goerr113 and unused linters across the codebase #21578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
ti-mo
requested review from
NikAleksandrov,
nebril,
aspsk,
kaworu and
jrajahalme
ti-mo
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
joestringer
reviewed
Oct 4, 2022
| @@ -900,104 +900,6 @@ func testExternalTrafficPolicyLocal(kubectl *helpers.Kubectl, ni *helpers.NodesI | |||
| } | |||
| } | |||
|
|
|||
| func testHostPort(kubectl *helpers.Kubectl, ni *helpers.NodesInfo) { | |||
There was a problem hiding this comment.
@cilium/sig-datapath do we have coverage of this now? I'm surprised this was unused.
There was a problem hiding this comment.
Looks like this wasn't cleaned up as part of the tests. We now have test/controlplane/services/nodeport testing that we populate lbmap correctly for HostPort and https://github.com/cilium/cilium-cli/blob/master/connectivity/tests/host.go tests e2e, so we should be good.
christarazi
approved these changes
Oct 4, 2022
|
All relevant tests passing, merging. |
ti-mo
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin. Now the
privileged_teststags in test files are gone, the unused linter can be useful again. Remove all code it flagged.Two false positives were spotted: functions that are only used in
Benchmark___functions. There have been a few bugs around this withExample_andTest_, but since it's just a few funcs for now, just//nolint:unusedthem.