-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: merge Alibaba install guide into quick install guide #21581
docs: merge Alibaba install guide into quick install guide #21581
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Two minor suggestions below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending Quentin's suggestions.
Signed-off-by: Yoyo Wu <yoyo19980720@126.com>
Signed-off-by: Yoyo Wu <yoyo19980720@126.com>
6d4403b
to
2a7f5a9
Compare
Hi @qmonnet Sorry for the late cause I am sick for a week, I have updated this PR per your comments, But @joestringer suggests us to merge the Alibaba one into the Installation using Helm page. How do you think about this idea? |
@yoyo-go Can you please provide some context, what's the motivation? I suppose you refer to this discussion and that this is because Alibaba does not support install through the Cilium CLI? In that case, yes, it's probably better to move it to the Helm page instead. |
…guide Signed-off-by: Yoyo Wu <yoyo19980720@126.com>
@qmonnet Yes that is the discussion, and I have updated the Helm page, and add a ref in our quick installation guide. Please have a look and let me know if this PR is ready. |
Thanks! But wasn't Joe's comment about adding the instructions to the Helm page only? |
@qmonnet What's the question? At a glance, the changes look roughly right:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, I got confused when reviewing the PR earlier today and thought we were adding the instructions both to the Helm page and the Quick install guide (where we in fact redirect to the Helm page). Sorry for the noise and thanks for taking a look.
All good then, let's get this merged! Just waiting for the Travis build just in case.
According to the slack thread with @joestringer , we diecide to merge the Alibaba ACK install guide into the Cilium quick install guide, as a new tab named
Alibaba ACK
.@qmonnet @lizrice @xmulligan Please let me know if you have any comment on it.