Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix link to CNCF CoC #21616

Merged
merged 1 commit into from
Oct 13, 2022
Merged

fix link to CNCF CoC #21616

merged 1 commit into from
Oct 13, 2022

Conversation

xmulligan
Copy link
Member

Signed-off-by: Bill Mulligan billmulligan516@gmail.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #issue-number

Fix broken link to CNCF CoC

@xmulligan
fix link to CNCF CoC
339c2b6 
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
@xmulligan xmulligan requested a review from a team as a code owner October 7, 2022 09:18
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 7, 2022
@sayboras sayboras added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Oct 7, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 7, 2022
@sayboras sayboras added release-note/misc This PR makes changes that have no direct user impact. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. and removed release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Oct 10, 2022
aditighag
aditighag approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aditighag aditighag added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 13, 2022
@qmonnet qmonnet merged commit a873d26 into master Oct 13, 2022
@qmonnet qmonnet deleted the xmulligan-patch-1 branch October 13, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

@aditighag aditighag aditighag approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xmulligan @sayboras @aditighag @qmonnet