Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: Document missing bpf ctTcpMax ctAnyMax natMax neighMax #21627

Merged
merged 1 commit into from
Oct 10, 2022
Merged

helm: Document missing bpf ctTcpMax ctAnyMax natMax neighMax #21627

merged 1 commit into from
Oct 10, 2022

Conversation

vincentmli
Copy link
Contributor

This is follow-up of #21195 to
continue to document missing helm options.

Signed-off-by: Vincent Li v.li@f5.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #issue-number

Document missing bpf ctTcpMax ctAnyMax natMax neighMax helm option

@vincentmli
helm: Document missing bpf ctTcpMax/ctAnyMax/natMax/neighMax
3c77661 
This is follow-up of cilium#21195
to continue to document missing helm options.

Signed-off-by: Vincent Li <v.li@f5.com>
@vincentmli vincentmli requested review from a team as code owners October 7, 2022 16:41
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 7, 2022
gandro
gandro approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@gandro gandro added release-note/misc This PR makes changes that have no direct user impact. area/helm Impacts helm charts and user deployment experience labels Oct 10, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 10, 2022
@gandro gandro added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Oct 10, 2022
squeed
squeed approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@squeed squeed added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 10, 2022
@sayboras sayboras merged commit f3b9ef3 into cilium:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@squeed squeed squeed approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/helm Impacts helm charts and user deployment experience ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vincentmli @gandro @squeed @sayboras