consolidate_go_stacktrace.py: Use relative paths by default #21673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consolidate_go_stacktrace.py changes Cilium file prefix to // by default, which is not very useful. Convert Cilium file paths to relative paths instead. This commit does not change the behavior when --source-dir is specified. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added
the
release-note/misc
|
tested both with and without
also validated that relative paths work with goland:
|
michi-covalent
commented
Oct 11, 2022
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env python | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
not directly related to this pr, it's probably better which python version is expected 馃憖
aditighag
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
I haven't verified the changes with the script, but your example looks reasonable to me - #21673 (comment).
also validated that relative paths work with goland:
馃殌 It'll be great if we include the steps somewhere. Can you add the example in the PR description for now? Thanks!
michi-covalent
added
the
ready-to-merge
|
this pr only touches consolidate_go_stacktrace.py so no need for a full CI run. marking it ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consolidate_go_stacktrace.py changes Cilium file prefix to // by default, which is not very useful. Convert Cilium file paths to relative paths instead. This commit does not change the behavior when --source-dir is specified.
to paste stack trace to goland:
shift-shiftto open global searchAnalyze Stack Trace or Thread Dump...OK馃殌Signed-off-by: Michi Mutsuzaki michi@isovalent.com