Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPAM: fix ipam owner check #21715

Merged
merged 1 commit into from
Oct 21, 2022
Merged

IPAM: fix ipam owner check #21715

merged 1 commit into from
Oct 21, 2022

Conversation

llhhbc
Copy link
Contributor

@llhhbc llhhbc commented Oct 13, 2022

Fix bug with incomplete check in MR #21379

Signed-off-by: LongHui Li longhui.li@woqutech.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #issue-number

<!-- Enter the release note text here if needed or remove this section! -->

@llhhbc
IPAM: fix ipam owner check
9b30a7f 
Fix bug with incomplete check in MR cilium#21379

Signed-off-by: LongHui Li <longhui.li@woqutech.com>
@llhhbc llhhbc requested a review from a team as a code owner October 13, 2022 02:25
@llhhbc llhhbc requested a review from gandro October 13, 2022 02:25
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 13, 2022
@llhhbc llhhbc mentioned this pull request Oct 13, 2022
Closed
7 tasks
@gandro gandro added the release-note/misc This PR makes changes that have no direct user impact. label Oct 13, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 13, 2022
@gandro
Copy link
Member

gandro commented Oct 13, 2022

/test

@gandro
Copy link
Member

gandro commented Oct 13, 2022

/test-1.16-4.9

@gandro
Copy link
Member

gandro commented Oct 13, 2022

/test-1.23-5.4

@llhhbc
Copy link
Contributor Author

llhhbc commented Oct 15, 2022

/test-1.16-4.9

@llhhbc llhhbc requested a review from gandro October 15, 2022 12:17
@aanm aanm merged commit 5facf8a into cilium:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@gandro gandro Awaiting requested review from gandro

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@llhhbc @gandro @aanm