EgressGW cleanups #21719
Merged
EgressGW cleanups #21719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianwiedmann
added
sig/datapath
|
/test |
julianwiedmann
force-pushed
the
egressgw-cleanups
branch
from
0c958fc
to
969199a
Compare
|
/test-1.25-net-next |
|
/test |
|
CI failures in |
sahid
reviewed
Oct 18, 2022
jibi
reviewed
Oct 19, 2022
Move most of the Egress Gateway-specific code into its header file, so that readers don't have to concern themselves with all the details. Fixes: cilium#19785 Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
encap_and_redirect_with_nodeid() doesn't do any tunnel lookup. Consequently it also doesn't return DROP_NO_TUNNEL_ENDPOINT. None of the callers is trying to handle such an error either, so this was presumably just a copy&paste typo. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
In a direct-routing config, we don't actually require the TUNNEL_MAP for EgressGW. In the from-container path, handle_ipv4_from_lxc() gets the tunnel_endpoint from the EgressGW policy (and can trust that it's != 0). So extract an optimized __encap_and_redirect_lxc() that doesn't depend on TUNNEL_MAP. In the reply path, rev_nodeport_lb4() queries the IPCache to obtain the source node of an EgressGW connection. If that fails, there's no further fallback to the TUNNEL_MAP. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
egressgw-cleanups
branch
from
969199a
to
c9a825c
Compare
|
/test Job 'Cilium-PR-K8s-1.23-kernel-5.4' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
|
/test-1.23-5.4 |
|
Travis fail is #21730. |
|
@jibi - as discussed offline. Slightly changed the helper layout, so that they focus on wrapping the call to |
jibi
approved these changes
Oct 25, 2022
julianwiedmann
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls various pieces of EgressGW code into
egress_policies.h. We also clean up the unused dependency onTUNNEL_MAP.Fixes: #19785