Use rate instead of irate in Hubble L7 workloads dashboard #21791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially I used irate because I was thinking these requests could be considered "fast moving", but irate only uses the most recent 2 datapoints for calculating rate, which causes graphs to fluctuate between the extremes a lot more than rate does. Rate will use all datapoints in the range vector, providing smoother graphs that actually better represent the data. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
michi-covalent
approved these changes
Oct 18, 2022
rolinh
added
sig/hubble
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
rolinh
approved these changes
Oct 18, 2022
tommyp1ckles
approved these changes
Oct 18, 2022
kaworu
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I used irate because I was thinking these requests could be considered "fast moving", but irate only uses the most recent 2 datapoints for calculating rate, which causes graphs to fluctuate between the extremes a lot more than rate does. Rate will use all datapoints in the range vector, providing smoother graphs that actually better represent the data.
In particular, the error rate graph previously jumped from 100% to 0% on basically any changes to the value. See the screenshots for a before/after comparison.
Before:
After:
