resource: Make the resource lazy by default #21862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
The practical use-case for this is: https://github.com/cilium/cilium/pull/21764/files#r1003189088 |
joamaki
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
joamaki
force-pushed
the
pr/joamaki/lazy-resource
branch
from
6569f3e
to
ab488d9
Compare
squeed
reviewed
Oct 24, 2022
| @@ -135,9 +143,34 @@ func (r *resource[T]) pushDelete(lastState any) { | |||
| } | |||
|
|
|||
| func (r *resource[T]) Start(startCtx hive.HookContext) error { | |||
| r.wg.Add(1) | |||
There was a problem hiding this comment.
Do we even really need Start() anymore?
There was a problem hiding this comment.
We still want this to wait until being told to start, e.g. we don't want "cilium-agent objects" inspection to actually start pulling data from api-server, and I don't see any reason to forbid Observe calls from constructors.
joamaki
force-pushed
the
pr/joamaki/lazy-resource
branch
from
ab488d9
to
a1ecd6e
Compare
For some resource kinds we only have observers if a feature has been enabled. Rather than guarding the creating of resource based on a set of "enabled" flags, make the resource lazy and only start the informer when the first observer (or call to Store()) is seen. Signed-off-by: Jussi Maki <jussi@isovalent.com>
joamaki
force-pushed
the
pr/joamaki/lazy-resource
branch
from
a1ecd6e
to
ce61e71
Compare
dylandreimerink
approved these changes
Oct 24, 2022
squeed
approved these changes
Oct 26, 2022
joamaki
added
the
ready-to-merge
|
|
christarazi
added
area/daemon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some resource kinds we only have observers if a feature has been enabled. Rather than guarding the creating of resource based on a set of "enabled" flags, make the resource lazy and only start the informer when the first observer (or call to Store()) is seen.