Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Reword note in Azure CNI chaining documentation #21897

Merged
merged 1 commit into from Oct 28, 2022
Merged

docs: Reword note in Azure CNI chaining documentation #21897

merged 1 commit into from Oct 28, 2022

Conversation

wedaly
Copy link
Contributor

@wedaly wedaly commented Oct 26, 2022 •
edited by qmonnet

Clarify that Azure CNI chaining is different than Azure CNI Powered by Cilium

Clarify in documentation that Azure CNI chaining is different from Azure CNI powered by Cilium.

@wedaly
docs: Reword note in Azure CNI chaining documentation
b1a67e3 
Clarify that Azure CNI chaining is different than
Azure CNI Powered by Cilium.

Signed-off-by: Will Daly <widaly@microsoft.com>
@wedaly wedaly requested review from a team as code owners October 26, 2022 19:46
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 26, 2022
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Oct 27, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 27, 2022
qmonnet
qmonnet approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.17 Oct 27, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.11 Oct 27, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.12.4 Oct 27, 2022
@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 27, 2022
sayboras
sayboras approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@nbusseneau
Copy link
Member

@wedaly Thanks for your contribution!

@nbusseneau nbusseneau merged commit b3cd077 into cilium:master Oct 28, 2022
@wedaly wedaly deleted the update-azure-cni-docs branch October 28, 2022 13:07
@pchaigno pchaigno mentioned this pull request Nov 7, 2022
Merged
@pchaigno pchaigno mentioned this pull request Nov 9, 2022
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.12 in 1.12.4 Nov 9, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.11 Nov 9, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.11 Nov 9, 2022
@pchaigno pchaigno mentioned this pull request Nov 9, 2022
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.17 Nov 9, 2022
@michi-covalent michi-covalent added this to Backport pending to v1.10 in 1.10.18 Nov 15, 2022
@michi-covalent michi-covalent removed this from Backport pending to v1.10 in 1.10.17 Nov 15, 2022
This was referenced Nov 15, 2022
Merged
Closed
@michi-covalent michi-covalent added this to Backport pending to v1.12 in 1.12.5 Nov 16, 2022
@michi-covalent michi-covalent removed this from Backport pending to v1.12 in 1.12.4 Nov 16, 2022
This was referenced Nov 16, 2022
Merged
Merged
@joestringer joestringer added this to Backport done to v1.10 in 1.10.17 Nov 18, 2022
@joestringer joestringer moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.11 Nov 18, 2022
@joestringer joestringer added this to Backport done to v1.12 in 1.12.4 Nov 18, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport done to v1.12 to Backport pending to v1.12 in 1.12.4 Nov 18, 2022
@joestringer joestringer added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Nov 18, 2022
@joestringer joestringer moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.4 Nov 18, 2022
@joestringer joestringer added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Nov 18, 2022
@joestringer joestringer removed this from Backport pending to v1.10 in 1.10.18 Nov 18, 2022
@joestringer joestringer removed this from Backport pending to v1.12 in 1.12.5 Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@sayboras sayboras sayboras approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.17
Backport done to v1.10
1.11.11
Backport done to v1.11
1.12.4
Backport done to v1.12
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@wedaly @nbusseneau @tommyp1ckles @sayboras @qmonnet @joestringer @pchaigno