New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix deployment resource type output #22002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, and thanks! Could you please provide some context on what the change is necessary? (Typically, linking to f4ec8ea in the commit description).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, thanks. It would be nice to include the details of the corresponding commit as Quentin mentioned, but as a first PR focused primarily on docs I'm not too worried about it.
I've allowed the CI to run to check the docs build correctly.
Smoke test hit known flake #22168 . Docs test passed. |
I'm sorry I forgot to modify commit. I'll change the commit description as soon as possible. |
OK, feel free to ping me when you have updated the PR. |
a16b3f9
to
e4c1306
Compare
@joestringer I have updated the commit description, PTAL. Thanks a lot. |
Done, PTAL. |
Thanks, merged. |
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.
fix deployment apiversion error
Fixes: #issue-number