Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of KPR=probe and socket-LB protocols #22083

Merged
merged 8 commits into from
Nov 17, 2022
Merged

Get rid of KPR=probe and socket-LB protocols #22083

merged 8 commits into from
Nov 17, 2022

Conversation

brb
Copy link
Member

@brb brb commented Nov 10, 2022 •
edited
Loading

Both were deprecated in v1.12, and were scheduled for removal in v1.13.

Fix #22076
Fix #22077

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 10, 2022
@brb brb force-pushed the pr/brb/rm-kpr-probe-and-host-reach-svc branch 4 times, most recently from 75b79c6 to 39729ef Compare November 11, 2022 15:38
@brb brb added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Nov 11, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 11, 2022
@brb brb added kind/cleanup This includes no functional changes. release-blocker/1.13 This issue will prevent the release of the next version of Cilium. labels Nov 11, 2022
@brb brb changed the title WIP: rm KPR=probe and host-reachable svc leftovers Get rid of KPR=probe and host-reachable svc leftovers Nov 11, 2022
@brb brb changed the title Get rid of KPR=probe and host-reachable svc leftovers Get rid of KPR=probe and socket-LB protocols Nov 11, 2022
@brb
Copy link
Member Author

brb commented Nov 11, 2022

/test

@brb brb marked this pull request as ready for review November 11, 2022 19:35
@brb brb requested review from a team as code owners November 11, 2022 19:36
@brb brb requested review from tklauser and gandro November 11, 2022 19:36
gandro
gandro approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agent and Helm looks good to me!

ti-mo
ti-mo reviewed Nov 14, 2022
View reviewed changes
Copy link
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. init.sh removals always welcome! One minor comment.

Heads up @rgo3

pkg/option/config.go Outdated Show resolved Hide resolved
brb added a commit to cilium/cilium-cli that referenced this pull request Nov 14, 2022
@brb
Get rid of kube-proxy-replacement=probe
d165d45 
It is going to removed in the Cilium v1.13. See
cilium/cilium#22083.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb mentioned this pull request Nov 14, 2022
Merged
@brb
Copy link
Member Author

brb commented Nov 14, 2022 •
edited
Loading

The ci-external failure is legit:

Error: unknown flag: --enable-host-reachable-services

This is coming from https://github.com/cilium/cilium-cli/blob/master/clustermesh/clustermesh.go#L1485 😞

Fix cilium/cilium-cli#1216.

@brb brb mentioned this pull request Nov 14, 2022
Merged
tklauser pushed a commit to cilium/cilium-cli that referenced this pull request Nov 14, 2022
@brb @tklauser
Get rid of kube-proxy-replacement=probe
3068335 
It is going to removed in the Cilium v1.13. See
cilium/cilium#22083.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
daemon: Remove KPR=probe
4052008 
The option was deprecated in v1.12, and it can be removed in v1.13.

The KPR=probe was never ending source of confusion for users and us, so
kthnxbye.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
daemon,bpf: Remove socket-LB protocols
6839d2e 
Deprecated in v1.12, scheduled to be removed in v1.13.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
bpf: Get rid of socket-LB proto defines in complex tests
c8f028b 
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
helm: Remove hostServices.protocols
5365afe 
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
docs: Mention rm KPR=probe and socket-LB proto in upgrade guide
cebdbe4 
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
gh/workflows: Bump cilium-cli vsn
f4a1f3c 
To include the fix cilium/cilium-cli#1216.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
daemon,bpf: Get rid of host-reachable svc naming leftovers
5f47ff1 
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
daemon: Remove host-reachable svc from status
9f735eb 
It's been replaced by the SocketLB field.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the pr/brb/rm-kpr-probe-and-host-reach-svc branch from 39729ef to 9f735eb Compare November 15, 2022 09:47
@brb brb requested review from a team as code owners November 15, 2022 09:47
@brb
Copy link
Member Author

brb commented Nov 15, 2022

/test

@brb
Copy link
Member Author

brb commented Nov 15, 2022

The Jenkins CI hit the IPSec flakes, while ci-multicluster and ci-external-workloads are waiting for #22140.

@brb
Copy link
Member Author

brb commented Nov 17, 2022

The previously failing ci-external-workloads passed: https://github.com/cilium/cilium/actions/runs/3490968748/jobs/5843060026. Marking as ready to merge.

@brb brb force-pushed the pr/brb/rm-kpr-probe-and-host-reach-svc branch from 195548d to 9f735eb Compare November 17, 2022 19:08
@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 17, 2022
@tklauser tklauser merged commit b1aa537 into master Nov 17, 2022
@tklauser tklauser deleted the pr/brb/rm-kpr-probe-and-host-reach-svc branch November 17, 2022 22:40
michi-covalent pushed a commit to michi-covalent/cilium that referenced this pull request May 30, 2023
@brb @michi-covalent
Get rid of kube-proxy-replacement=probe
99b2a03 
It is going to removed in the Cilium v1.13. See
cilium#22083.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@ti-mo ti-mo ti-mo left review comments

@gandro gandro gandro approved these changes

@nathanjsweet nathanjsweet nathanjsweet approved these changes

@tklauser tklauser tklauser approved these changes

@borkmann borkmann borkmann approved these changes

@ldelossa ldelossa ldelossa approved these changes

@nbusseneau nbusseneau Awaiting requested review from nbusseneau nbusseneau was automatically assigned from cilium/github-sec

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-blocker/1.13 This issue will prevent the release of the next version of Cilium. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove host-reachable svc leftovers agent: Remove KPR=probe
8 participants
@brb @gandro @nathanjsweet @tklauser @borkmann @pchaigno @ti-mo @ldelossa