Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtu, node: fix build on all non-linux platforms #22232

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

tklauser
Copy link
Member

This package is imported as a transitive dependency in cilium-cli which is built for linux, darwin and windows. Make sure the package compiles on all these platforms.

Ref. cilium/cilium-cli#958 (comment)
For #16843

Marking as needs-backport/1.12 so we can vendor the next v1.12.n release into cilium-cli again.

This package is imported as a transitive dependency in cilium-cli which
is built for linux, darwin and windows. Make sure the package compiles
on all these platforms.

Ref. cilium/cilium-cli#958 (comment)
For #16843

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.12 labels Nov 17, 2022
@tklauser tklauser requested review from a team as code owners November 17, 2022 14:58
Copy link
Member

@dylandreimerink dylandreimerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tklauser tklauser merged commit bf3532e into master Nov 18, 2022
@tklauser tklauser deleted the pr/tklauser/cross-build-fix branch November 18, 2022 14:03
@jrajahalme jrajahalme added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants