Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: split the image tag update in two steps #22268

Merged
merged 1 commit into from Nov 18, 2022

Conversation

aanm
Copy link
Member

@aanm aanm commented Nov 18, 2022

If the images are not created, because they are already available in the docker image repository, they will have an empty image digest set and the image tag replacement will wrongly use this empty digest.

Signed-off-by: André Martins andre@cilium.io

If the images are not created, because they are already available in the
docker image repository, they will have an empty image digest set and
the image tag replacement will wrongly use this empty digest.

Fixes: c5a7787 ("add auto-commit capability to build base images GH workflow")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.10 labels Nov 18, 2022
@aanm aanm requested review from a team as code owners November 18, 2022 15:57
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.12 Nov 18, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.18 Nov 18, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.12.5 Nov 18, 2022
@aanm aanm merged commit eafc6b1 into master Nov 18, 2022
@aanm aanm deleted the pr/fix-auto-base branch November 18, 2022 23:19
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.12 in 1.12.5 Nov 18, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.12 in 1.12.5 Nov 18, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.12 Nov 18, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.18 Nov 18, 2022
@aanm aanm added backport-done/1.10 backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Nov 18, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.5 Nov 18, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.5 Nov 18, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.5 Nov 18, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.18 Nov 18, 2022
@joestringer joestringer moved this from Backport pending to v1.10 to Backport pending to v1.11 in 1.11.12 Dec 15, 2022
@joestringer joestringer removed this from Backport pending to v1.11 in 1.11.12 Dec 15, 2022
@joestringer joestringer added this to Backport pending to v1.11 in 1.11.13 Dec 15, 2022
@michi-covalent michi-covalent added this to Backport pending to v1.11 in 1.11.14 Jan 26, 2023
@michi-covalent michi-covalent removed this from Backport pending to v1.11 in 1.11.13 Jan 26, 2023
@michi-covalent michi-covalent added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Jan 26, 2023
@michi-covalent michi-covalent removed this from Backport pending to v1.11 in 1.11.14 Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.18
Backport done to v1.10
1.12.5
Backport done to v1.12
Development

Successfully merging this pull request may close these issues.

None yet

4 participants