-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm: Automount Init Container Resources #22384
Helm: Automount Init Container Resources #22384
Conversation
Commit 57ad7b2279b2720a82a3cdabf0bcc61462bf6768 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
57ad7b2
to
ce3b35c
Compare
Fixed. This was due to using the Github function to merge the actual master in this branch. I simply made a rebase now, so this PR is only the one relevant commit. |
ce3b35c
to
4fbeb91
Compare
I am not quite sure why this PR is not merge-able. As far as I can see, its the label |
@shaardie that is address now. It was missing the release note label 🙂 Unfortunately CI is currently failing, can you add the missing word in the spellcheck list as mentioned in https://github.com/cilium/cilium/actions/runs/3572847762/jobs/6091808637? Thank you. |
This patch adds the option to configure the resources of the init container automounting the cgroups. Signed-off-by: Sven Haardiek <sven.haardiek@uni-muenster.de>
4fbeb91
to
870927d
Compare
Oh, I missed that. I hope it is fixed now. |
Looks good, thanks for the contribution @shaardie. |
This patch adds the option to configure the resources of the init container automounting the cgroups.
Signed-off-by: Sven Haardiek sven.haardiek@uni-muenster.de
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.
This patch adds the option to configure the resources of the cgroups automount init Container in the Cilium Agent DaemonSet. Some clusters have a strict rules of setting those resources for scaling and quota handling and partly have policies in place not allowing containers or init containers without resources. So this makes it easier to use the Cilium Helm Chart on those clusters without patching.