Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Automount Init Container Resources #22384

Merged

Conversation

shaardie
Copy link
Contributor

This patch adds the option to configure the resources of the init container automounting the cgroups.

Signed-off-by: Sven Haardiek sven.haardiek@uni-muenster.de

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

This patch adds the option to configure the resources of the cgroups automount init Container in the Cilium Agent DaemonSet. Some clusters have a strict rules of setting those resources for scaling and quota handling and partly have policies in place not allowing containers or init containers without resources. So this makes it easier to use the Cilium Helm Chart on those clusters without patching.

Add option to configure the resources of the cgroups automount init Container in the Cilium Agent DaemonSet.

@shaardie shaardie requested review from a team as code owners November 28, 2022 09:54
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 28, 2022
@maintainer-s-little-helper
Copy link

Commit 57ad7b2279b2720a82a3cdabf0bcc61462bf6768 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 28, 2022
@shaardie shaardie force-pushed the automount-init-container-resources branch from 57ad7b2 to ce3b35c Compare November 28, 2022 09:58
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 28, 2022
@shaardie
Copy link
Contributor Author

Commit 57ad7b2 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

Fixed. This was due to using the Github function to merge the actual master in this branch. I simply made a rebase now, so this PR is only the one relevant commit.

@shaardie shaardie force-pushed the automount-init-container-resources branch from ce3b35c to 4fbeb91 Compare November 29, 2022 09:42
@shaardie
Copy link
Contributor Author

I am not quite sure why this PR is not merge-able. As far as I can see, its the label dont-merge/needs-release-note-label, which suggest that I have to write a release note, but there is one in the PR description 🤷

@aanm aanm added the kind/community-contribution This was a contribution made by a community member. label Dec 1, 2022
@joestringer joestringer added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Dec 4, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 4, 2022
@aanm
Copy link
Member

aanm commented Dec 5, 2022

@shaardie that is address now. It was missing the release note label 🙂

Unfortunately CI is currently failing, can you add the missing word in the spellcheck list as mentioned in https://github.com/cilium/cilium/actions/runs/3572847762/jobs/6091808637? Thank you.

This patch adds the option to configure the resources of the init container
automounting the cgroups.

Signed-off-by: Sven Haardiek <sven.haardiek@uni-muenster.de>
@shaardie shaardie force-pushed the automount-init-container-resources branch from 4fbeb91 to 870927d Compare December 5, 2022 09:26
@shaardie shaardie requested a review from a team as a code owner December 5, 2022 09:26
@shaardie
Copy link
Contributor Author

shaardie commented Dec 5, 2022

Unfortunately CI is currently failing, can you add the missing word in the spellcheck list as mentioned in https://github.com/cilium/cilium/actions/runs/3572847762/jobs/6091808637? Thank you.

Oh, I missed that. I hope it is fixed now.

@joestringer
Copy link
Member

Looks good, thanks for the contribution @shaardie.

@github-actions github-actions bot added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. kind/community-contribution This was a contribution made by a community member. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
Status: Released
Development

Successfully merging this pull request may close these issues.

None yet

7 participants