Add tests for hubble metrics handlers

[marqc]

PortDistributionHandler and TcpHandler.

Signed-off-by: Marek Chodor mchodor@google.com

Please ensure your pull request adheres to the following guidelines:

• For first time contributors, read Submitting a pull request
• All code is covered by unit and/or runtime tests where feasible.
• All commits contain a well written commit description including a title,
  description and a Fixes: #XXX line if the commit addresses a particular
  GitHub issue.
• If your commit description contains a Fixes: <commit-id> tag, then
  please add the commit author[s] as reviewer[s] to this issue.
• All commits are signed off. See the section Developer’s Certificate of Origin
• Provide a title or release-note blurb suitable for the release notes.
• Thanks for contributing!

Add tests for hubble metrics handlers: DropHandler, PortDistributionHandler and TcpHandler.

[chancez]

This is great, I'm really happy to see tests for the metrics, we really need these. I added few comments above, but in all the tests, there's no assertions against the actual metric values, so let's add that everywhere we're expecting a non-empty series.

[maintainer-s-little-helper]

Commit f4a279c9e272ba01ef92bbcbd43607a9d5ce66bf does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[chancez]

This looks good. Can you fix your commits and make sure everything passes the initial CI checks?

[chancez]

New tests look good to me.

[chancez]

You'll need to try and shorten the commit message.

Error: ERROR:CUSTOM: Please avoid long commit subjects (max: 75, found: 91)
42

[kaworu]

Thank you for the contribution @marqc patch LGTM!

[aanm]

/test

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sAgentPolicyTest Basic Test TLS policy

Failure Output

FAIL: Cannot connect from "app2-7fd4ddfc6-9gqv5" to 'https://www.lyft.com:443/privacy'

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

[rolinh]

Marking for v1.13 backport. This PR only adds unit tests to Hubble metrics and better test coverage is better overall in case of backport (assuming tests aren't flaky). As suggested by @gandro, I ran the test 1000 times and they always succeeded so I take it they're not flaky.

$ go test -count 1000 -race ./...
ok      github.com/cilium/cilium/pkg/hubble/metrics     0.081s
ok      github.com/cilium/cilium/pkg/hubble/metrics/api 1.291s
?       github.com/cilium/cilium/pkg/hubble/metrics/dns [no test files]
ok      github.com/cilium/cilium/pkg/hubble/metrics/drop        0.514s
ok      github.com/cilium/cilium/pkg/hubble/metrics/flow        0.665s
ok      github.com/cilium/cilium/pkg/hubble/metrics/flows-to-world      2.506s
ok      github.com/cilium/cilium/pkg/hubble/metrics/http        3.391s
?       github.com/cilium/cilium/pkg/hubble/metrics/icmp        [no test files]
?       github.com/cilium/cilium/pkg/hubble/metrics/kafka       [no test files]
ok      github.com/cilium/cilium/pkg/hubble/metrics/policy      0.443s
ok      github.com/cilium/cilium/pkg/hubble/metrics/port-distribution   0.710s
ok      github.com/cilium/cilium/pkg/hubble/metrics/tcp 1.989s

[rolinh]

/test

Job 'Cilium-PR-K8s-1.24-kernel-5.4' failed:

Click to show.

Test Name

K8sDatapathConfig Host firewall With native routing and endpoint routes

Failure Output

FAIL: Found 1 k8s-app=cilium logs matching list of errors that must be investigated:

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.24-kernel-5.4 so I can create one.

[rolinh]

Not sure why Travis doesn't get triggered, it's basically the only truly relevant CI test. Let's try closing the PR and re-opening it.

[marqc]

Looks like the testing environment is not stable. I rebased to master branch HEAD and re-pushed changes to trigger tests again.

[marqc]

Looks like the testing environment is not stable. I rebased to master branch HEAD and re-pushed changes to trigger tests again.

Unfortunately still failing on some k8s setup checks https://github.com/cilium/cilium/actions/runs/3703427000/jobs/6274901939
The reported problem is a missing coredns pod which seems unrelated to cilium code.

Test failed on this check https://github.com/cilium/cilium/blob/master/.github/workflows/conformance-gateway-api.yaml#L124 with info that coredns pod does not exist. Later in post test cluster dump there is another coredns pod visible healthy and ready. I tried performing these test steps manually on my local machine and I haven't seen any problems. Coredns does not transition into ready state until cilium gets installed, but right after that it becomes healthy.

/test

[rolinh]

@marqc Some tests are flaky indeed, let's ignore the test failures as long as the Travis test is ✔️

[rolinh]

I'm not sure what's wrong with Travis and why it doesn't trigger. This PR only adds unit tests to Hubble metrics. I have run them 1000 times without any failures, thus marking this PR as ready to merge.