daemon/cmd: improve stale cilium endpoint error handling. #22600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
|
Going to convert this to a draft/CI debugging PR for the time being. The frequency of these errors in CI is concerning. |
|
/test-1.16-4.9 |
|
/test |
aanm
removed
the
kind/community-contribution
|
/test-1.16-4.9 |
2 similar comments
|
/test-1.16-4.9 |
|
/test-1.16-4.9 |
|
/test |
1 similar comment
|
/test |
|
/test-1.16-4.9 |
|
/test-1.24-5.4 |
|
/test-1.25-4.19 |
|
/test-1.26-net-next |
|
/test |
|
/test-1.16-4.9 |
|
/test-1.16-4.9 |
|
/test |
|
/test |
github-actions
bot
added
the
kind/community-contribution
tommyp1ckles
deleted the
pr/tommyp1ckles/improve-stale-cep-cleanup-error-handling
branch
joestringer
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.10
in 1.13.0-rc4
|
@tommyp1ckles This file doesn't exist in <= v1.12. Removing the needs-backport/* labels for those changes for now. |
This was referenced Jan 14, 2023
aanm
added
backport-done/1.12
18 tasks
joestringer
added
backport-done/1.11
This was referenced Jan 26, 2023
This was referenced Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid error logging on no-op cleanup situations to avoid breaking CI.
Previously, if stale CEP cleanup was attempted and the CiliumEndpoint was already gone it would log an error.
This would go on to fail CI, on tests enforcing zero error logs.
In the case where the error is a
k8serrors.NotFound, we don't need to consider this an error. This change differentiates between the two cases and logs info if its the no-op case.Signed-off-by: Tom Hadlaw tom.hadlaw@isovalent.com