Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon: Do not remove PERM L2 entries in L4LB #22676

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

brb
Copy link
Member

@brb brb commented Dec 12, 2022

In the L4LB mode, the PERM L2 entries are managed by users. So, in this mode Cilium should not mess with them.

Discovered while converting #22653.

In the L4LB mode, the PERM L2 entries are managed by users. So, in this
mode Cilium should not mess with them.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.12 labels Dec 12, 2022
@brb brb requested a review from borkmann December 12, 2022 09:21
@brb brb requested a review from a team as a code owner December 12, 2022 09:21
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.12.5 Dec 12, 2022
@brb brb added the needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch label Dec 12, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.13.0-rc4 Dec 12, 2022
@brb
Copy link
Member Author

brb commented Dec 12, 2022

/ci-l4lb

@brb brb closed this Dec 12, 2022
@brb brb reopened this Dec 12, 2022
@brb
Copy link
Member Author

brb commented Dec 12, 2022

/ci-l4lb

@borkmann borkmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 12, 2022
@borkmann borkmann merged commit ced77b3 into master Dec 12, 2022
@borkmann borkmann deleted the pr/brb/fix-l4lb-perm-entries-removal branch December 12, 2022 11:05
@joestringer joestringer added this to Needs backport from master in 1.12.6 Dec 15, 2022
@joestringer joestringer removed this from Needs backport from master in 1.12.5 Dec 15, 2022
@joestringer joestringer added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Dec 21, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.13 in 1.13.0-rc4 Dec 21, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.13 in 1.13.0-rc4 Dec 21, 2022
@joestringer joestringer added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Dec 22, 2022
@joestringer joestringer moved this from Backport pending to v1.13 to Backport done to v1.10 in 1.13.0-rc4 Dec 22, 2022
@aditighag aditighag added backport-pending/1.12 backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Jan 10, 2023
@michi-covalent michi-covalent moved this from Needs backport from master to Backport done to v1.12 in 1.12.6 Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.12.6
Backport done to v1.12
1.13.0-rc4
Backport done to v1.13
Development

Successfully merging this pull request may close these issues.

None yet

4 participants