proxylib: Downgrade noisy log msg to debug level #22848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log msg doesn't provide any useful / actionable information anyway, presumably unless you're debugging. Fixes: 69518a1 ("envoy: API update") Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
added
area/proxy
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
christarazi
removed
the
kind/community-contribution
sayboras
approved these changes
Dec 23, 2022
| @@ -183,7 +183,7 @@ func (ins *Instance) PolicyUpdate(resp *envoy_service_discovery.DiscoveryRespons | |||
| return fmt.Errorf("NPDS: Policy has no endpoint_ips") | |||
| } | |||
| for _, ip := range ips { | |||
| logrus.Infof("NPDS: Endpoint IP: %s", ip) | |||
| logrus.Debugf("NPDS: Endpoint IP: %s", ip) | |||
There was a problem hiding this comment.
this is un-related to this PR, we can just have one single log entry to print all ips together, something like below
logrus.Infof("NPDS: Endpoint IP: %v", strings.Join(ips, ","))or just
logrus.Debugf("NPDS: Endpoint IP: %v", ips)
|
Downgrading a log msg level shouldn't need a full CI run. We have an approving review above, marking ready to merge. |
christarazi
added
the
ready-to-merge
|
cc @jrajahalme |
sayboras
added
needs-backport/1.12
needs-backport/1.13
|
Nominate this PR for 1.13 and 1.12 backport, the main reason is to avoid noisy logs, which might cause issue for users to overlook the actual error. |
9 tasks
29 tasks
NikAleksandrov
added
backport-pending/1.13
youngnick
added
backport-done/1.12
jibi
added
the
backport-done/1.13
jibi
removed
the
backport-pending/1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log msg doesn't provide any useful / actionable information anyway,
presumably unless you're debugging.
Fixes: 69518a1 ("envoy: API update")
Signed-off-by: Chris Tarazi chris@isovalent.com