-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib: Add devcontainer configuration #22856
Conversation
a3da453
to
51a9170
Compare
c0fcf77
to
a70aa62
Compare
a70aa62
to
fae522b
Compare
827c0fb
to
6717421
Compare
6717421
to
a72b87f
Compare
The changes here are mainly related to local development, full CI is not required. |
a72b87f
to
b55e8ca
Compare
b55e8ca
to
68e382c
Compare
fc70aa8
to
310ffa0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit, otherwise LGTM thanks!
08cd5c8
to
efa03f6
Compare
This is to provide the quick way for new contributors to bootstrap development environment with [devcontainer], which is widely used in vscode as well as github [codespaces]. The docker image is completely re-used from cilium builder image. Minimum set of features (e.g. docker-in-docker) is enabled by default. While enabling more features is handy, it will increase the bootstrap time. Hence, only docker is enabled as required by Makefile targets (e.g helm-docs). [devcontainer]: https://code.visualstudio.com/docs/devcontainers/containers [codespaces]: https://docs.github.com/en/codespaces/setting-up-your-project-for-codespaces/introduction-to-dev-containers Signed-off-by: Tam Mach <tam.mach@cilium.io>
efa03f6
to
f72092a
Compare
f72092a
to
ff68cf7
Compare
ff68cf7
to
b2d323a
Compare
b2d323a
to
a8f1bed
Compare
Signed-off-by: Tam Mach <tam.mach@cilium.io>
a8f1bed
to
69b1dc6
Compare
Couple of forced push to rebase and update {builder,runtime} images. |
/test Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test Name
Failure Output
If it is a flake and a GitHub issue doesn't already exist to track it, comment |
Travis failure is due to the below issue, which will be fixed in #23329
|
Reviews are in, all jobs are passed except:
Mark this ready to merge so that this PR will show up for tophat. |
Description
This is to provide the quick way for new contributors to bootstrap
development environment with devcontainer, which is
widely used in vscode as well as github codespaces. The
docker image is completely re-used from cilium builder image.
Minimum set of features (e.g. docker-in-docker) is enabled by default.
While enabling more features is handy, it will increase the bootstrap
time. Hence, only docker is enabled as required by Makefile targets (e.g
helm-docs).
Signed-off-by: Tam Mach tam.mach@cilium.io
Testing
Please find below the snippet of local devcontainer with vscode