Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hubble: Use netip.Addr instead of net.IP in getter functions #23143

Merged
merged 3 commits into from
Mar 9, 2023
Merged

hubble: Use netip.Addr instead of net.IP in getter functions #23143

merged 3 commits into from
Mar 9, 2023

Commits on Mar 9, 2023

  1. endpointmanager: Use netip.Addr instead of net.IP in LookupIP 

    It's preparing to migrate Hubble getters (calling LookupIP) from net.IP to
netip.Addr.

Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
    @lambdanis
    lambdanis committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    b5adf18 View commit details
    Browse the repository at this point in the history

  2. dnsproxy: Rename targetServerAddr -> targetServerAddrStr 

    Only renaming a variable, to avoid confusion with netip.Addr. It's preparing to
migrate from net.IP to netip.Addr.

Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
    @lambdanis
    lambdanis committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    9422f28 View commit details
    Browse the repository at this point in the history

  3. hubble: Use netip.Addr instead of net.IP in getter functions 

    Various parts of Cilium now use netip.Addr instead of net.IP or custom IP types
internally, and other parts will likely be migrated soon. This patch updates
Hubble getters to take netip.Addr as an argument instead of net.IP. That will
reduce type conversions needed in Hubble. All getters handle invalid addresses.

Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
    @lambdanis
    lambdanis committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    e56cfc2 View commit details
    Browse the repository at this point in the history