Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh/workflows: Disable BPF masq in ci-datapath #23171

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

brb
Copy link
Member

@brb brb commented Jan 18, 2023

It seems to be broken in the direct routing mode. Disable for now in all configurations.

Successful run - https://github.com/cilium/cilium/actions/runs/3952387001/jobs/6767397972.

@brb brb added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jan 18, 2023
It seems to be broken in the direct routing mode. Disable for now in all
configurations.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the pr/brb/ci-dp-disable-bpf-masq branch 2 times, most recently from acb59fa to 0a693c1 Compare January 18, 2023 20:40
@brb brb marked this pull request as ready for review January 18, 2023 20:40
@brb brb requested review from a team as code owners January 18, 2023 20:40
@julianwiedmann
Copy link
Member

For the record, this is meant to fix the following fallout in the bpf-next test:

📋 Test Report
❌ 5/31 tests failed (12/237 actions), 0 tests skipped, 0 scenarios skipped:
Test [no-policies]:
connectivity test failed: 5 tests failed
❌ no-policies/pod-to-world/http-to-one.one.one.one-0: cilium-test/client-755fb678bd-r9qf5 (10.244.1.124) -> one.one.one.one-http (one.one.one.one:80)
❌ no-policies/pod-to-world/https-to-one.one.one.one-0: cilium-test/client-755fb678bd-r9qf5 (10.244.1.124) -> one.one.one.one-https (one.one.one.one:443)
❌ no-policies/pod-to-world/https-to-one.one.one.one-index-0: cilium-test/client-755fb678bd-r9qf5 (10.244.1.124) -> one.one.one.one-https-index (one.one.one.one:443)
❌ no-policies/pod-to-world/http-to-one.one.one.one-1: cilium-test/client2-5b97d7bc66-dm6bd (10.244.1.206) -> one.one.one.one-http (one.one.one.one:80)
❌ no-policies/pod-to-world/https-to-one.one.one.one-1: cilium-test/client2-5b97d7bc66-dm6bd (10.244.1.206) -> one.one.one.one-https (one.one.one.one:443)
❌ no-policies/pod-to-world/https-to-one.one.one.one-index-1: cilium-test/client2-5b97d7bc66-dm6bd (10.244.1.206) -> one.one.one.one-https-index (one.one.one.one:443)
Test [to-entities-world]:
❌ to-entities-world/pod-to-world/http-to-one.one.one.one-0: cilium-test/client-755fb678bd-r9qf5 (10.244.1.124) -> one.one.one.one-http (one.one.one.one:80)
❌ to-entities-world/pod-to-world/http-to-one.one.one.one-1: cilium-test/client2-5b97d7bc66-dm6bd (10.244.1.206) -> one.one.one.one-http (one.one.one.one:80)
Test [client-egress-l7]:
❌ client-egress-l7/pod-to-world/http-to-one.one.one.one-1: cilium-test/client2-5b97d7bc66-dm6bd (10.244.1.206) -> one.one.one.one-http (one.one.one.one:80)
Test [client-egress-l7-named-port]:
❌ client-egress-l7-named-port/pod-to-world/http-to-one.one.one.one-1: cilium-test/client2-5b97d7bc66-dm6bd (10.244.1.206) -> one.one.one.one-http (one.one.one.one:80)
Test [to-fqdns]:
❌ to-fqdns/pod-to-world/http-to-one.one.one.one-0: cilium-test/client-755fb678bd-r9qf5 (10.244.1.124) -> one.one.one.one-http (one.one.one.one:80)
❌ to-fqdns/pod-to-world/http-to-one.one.one.one-1: cilium-test/client2-5b97d7bc66-dm6bd (10.244.1.206) -> one.one.one.one-http (one.one.one.one:80)
Error: Process completed with exit code 1.

@squeed
Copy link
Contributor

squeed commented Jan 19, 2023

/test
(edit: sorry, wrong PR)

@squeed
Copy link
Contributor

squeed commented Jan 19, 2023

Is there a release-blocking issue to track re-enabling this test? Why is it broken?

@brb
Copy link
Member Author

brb commented Jan 23, 2023

Is there a release-blocking issue to track re-enabling this test? Why is it broken?

@squeed I'm currently investigating this. Could be just matter of the KIND configuration, and I will keep posted. Anyway, this should not prevent this PR from being merged.

Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an issue to track this and eventually reenable it?

@brb
Copy link
Member Author

brb commented Jan 23, 2023

Do we need an issue to track this and eventually reenable it?

👍 If I don't fix it by EOD, then I will create an issue.

@aanm aanm merged commit 4f57c6a into master Jan 23, 2023
@aanm aanm deleted the pr/brb/ci-dp-disable-bpf-masq branch January 23, 2023 09:56
@brb
Copy link
Member Author

brb commented Jan 24, 2023

#23283 🤔

@sayboras sayboras mentioned this pull request Jan 24, 2023
9 tasks
@sayboras sayboras added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jan 24, 2023
@aanm aanm added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants