Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Bump Hubble-UI images to v0.10.0 #23184

Merged
merged 1 commit into from
Jan 28, 2023
Merged

helm: Bump Hubble-UI images to v0.10.0 #23184

merged 1 commit into from
Jan 28, 2023

Conversation

pjbgf
Copy link
Contributor

@pjbgf pjbgf commented Jan 19, 2023

Bump Hubble images used on Helm chart to v0.10.0.

Update Helm Chart to use Hubble-UI v0.10.0 images by default.

@pjbgf pjbgf requested review from a team as code owners January 19, 2023 13:11
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 19, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 19, 2023
@tommyp1ckles
Copy link
Contributor

lgtm, but I'm not so familiar with hubble versions @michi-covalent does this make sense?

@sayboras sayboras requested a review from geakstr January 21, 2023 06:16
@sayboras
Copy link
Member

sayboras commented Jan 21, 2023

same point as above, just add Dima (who is hubble UI maintainer) as reviewer.

Also there is CI failure as per https://app.travis-ci.com/github/cilium/cilium/jobs/593729866

@sayboras sayboras removed their request for review January 21, 2023 06:23
@gandro gandro changed the title helm: Bump Hubble images to v0.10.0 helm: Bump Hubble-UI images to v0.10.0 Jan 23, 2023
@michi-covalent
Copy link
Contributor

the change looks good to me ✅ , you need to run make -C Documentation update-helm-values to update Documentation/helm-values.rst

@michi-covalent michi-covalent added the needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch label Jan 23, 2023
@pjbgf
Copy link
Contributor Author

pjbgf commented Jan 23, 2023

@michi-covalent thank you for the review, I updated the PR accordingly. PTAL

@michi-covalent michi-covalent added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jan 23, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 23, 2023
Signed-off-by: Paulo Gomes <pjbgf@linux.com>
@pjbgf
Copy link
Contributor Author

pjbgf commented Jan 24, 2023

The arm64 failed test seems to be orthogonal:

docker: 'buildx' is not a docker command.
See 'docker --help'
  CHECK   vetting all packages...
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃   FAIL  package: github.com/cilium/cilium/pkg/k8s/identitybackend   ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛

--- FAIL: TestGetIdentity (0.61s)
                                 
    --- FAIL: TestGetIdentity/Duplicated_identity (0.03s)
                                                         
    identity_test.go:218: Expected key 10, got 11

Rebasing now to trigger another run.

@sayboras
Copy link
Member

┃ FAIL package: github.com/cilium/cilium/pkg/k8s/identitybackend ┃

the above failure is not related to this PR, but more about the flake. I initiated one convo in Cilium development channel

https://cilium.slack.com/archives/C2B917YHE/p1674537258592139

@pjbgf
Copy link
Contributor Author

pjbgf commented Jan 27, 2023

Please let me know when this would be OK for merge so I can do another rebase.

@rolinh
Copy link
Member

rolinh commented Jan 27, 2023

Please let me know when this would be OK for merge so I can do another rebase.

I think we can label the PR as ready to merge. Hubble UI is not covered in CI tests and Helm lint tests are ✔️

@rolinh rolinh added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 27, 2023
@aanm aanm merged commit 59f4d11 into cilium:master Jan 28, 2023
@pjbgf pjbgf deleted the bump-hubble branch January 28, 2023 18:29
@qmonnet qmonnet mentioned this pull request Jan 31, 2023
27 tasks
@qmonnet qmonnet removed the needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch label Jan 31, 2023
@qmonnet qmonnet added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants