test: Unquarantine tests for iptables-based masquerading #23228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI
christarazi
approved these changes
Jan 23, 2023
YutaroHayakawa
approved these changes
Jan 24, 2023
pchaigno
added
the
ready-to-merge
|
@pchaigno needs rebase. |
Commit 1732c21 ("test, jenkinsfile: Clean up natnetworks in CI after test run") added some clean up for VirtualBox state in an effort to fix the flakes affecting the iptables-based masquerading tests. DataStudio [1] now shows that this effort was fruitful: those tests didn't fail in the quarantined runs. The few failures observed on the dashboard are actually cases where all tests failed because of a failure to retrieve Cilium container images (so unrelated). This commit unquarantines the two tests. They had been quarantined by 0fc1188 ("test/DatapathConfiguration: Quarantine 'Encapsulation'") more than a year ago... 1 - https://datastudio.google.com/s/rhLunJ7r1Dw Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
unquarantine-iptables-masquerading-tests
branch
from
4d70f20
to
75d8e78
Compare
|
k8s-1.16-kernel-4.9 hit known flake #22749 (I confirmed with the echo-c-host logs). Other CI jobs are passing. Reviews are in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1732c21 ("test, jenkinsfile: Clean up natnetworks in CI after test run") added some clean up for VirtualBox state in an effort to fix the flakes affecting the iptables-based masquerading tests.
DataStudio [1] now shows that this effort was fruitful: those tests didn't fail in the quarantined runs. The few failures observed on the dashboard are actually cases where all tests failed because of a failure to retrieve Cilium container images (so unrelated).
This commit unquarantines the two tests. They had been quarantined by 0fc1188 ("test/DatapathConfiguration: Quarantine 'Encapsulation'") more than a year ago...
1 - https://datastudio.google.com/s/rhLunJ7r1Dw
Fixes: #17353.