bgp: Replaced localNodeStore based nodespecer with resources #23276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylandreimerink
added
the
dont-merge/preview-only
maintainer-s-little-helper
bot
added
backport/1.13
github-actions
bot
added
the
kind/community-contribution
dylandreimerink
changed the title
dylandreimerink
added
kind/bug
|
/test |
|
/test-backport-1.13 |
[ modified upstream commit 9edbece ] In PR cilium#22397 the nodespecer implementation was turned into a cell. That implementation used the localNodeStore to get access to a generic node object that would contain annotations, labels and podCIDRs. However, it turns out that the localNodeStore doesn't function as one might expect and didn't register updates properly. This commit changes the implementation to use resources to subscribe to changes in the node objects of the API server directly. This is very much like the old pre-modularization implementation, but now using resources instead of informers. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/fix-bgp-annotation-alt
branch
from
11a34a9
to
0dcb39f
Compare
|
/test-backport-1.13 Job 'Cilium-PR-K8s-1.24-kernel-4.9' hit: #22578 (96.78% similarity) Job 'Cilium-PR-K8s-1.21-kernel-4.9' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
|
Alright, tests seem mostly ok. We are hitting flake #21519 in The ConformanceGKE test is failing on an issue for which I have not yet been able to find an existing report. But the other backport PR #23284 is also hitting the same issue, so it might be that its broken in the target branch. So ignoring flakes, we should be good to go, marking ready-to-merge. |
dylandreimerink
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #22397 the nodespecer implementation was turned into a cell. That implementation used the localNodeStore to get access to a generic node object that would contain annotations, labels and podCIDRs.
However, it turns out that the localNodeStore doesn't function as one might expect and didn't register updates properly.
This PR changes the implementation to use resources to subscribe to changes in the node objects of the API server directly. This is very much like the old pre-modularization implementation, but now using resources instead of informers.
Fixes: #23155