Revert "datapath: Remove 2005 route table" #23346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
kind/bug
|
Should this be marked as release blocker, since it breaks CI reliably on master K8s 1.20-1.24 kernel 4.9? cc @joestringer @aanm |
|
@nbusseneau it looks like this was not yet backported to v1.13, so it doesn't need to impact the release. |
|
Oh yah, didn't think this through. |
|
/test Job 'Cilium-PR-K8s-1.16-kernel-4.9' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
This reverts commit 2b58e0f. After removing the 2005 rtable to fix the L7 issue, the kube-proxy NodePort with L7 netpol started to fail in the CI. After taking closer look, the removal of the rtable is causing the reply from the envoy proxy to be passed to lo instead of cilium_host : 14:54:33.585708 eth0 In IP6 fc00:f853:ccd:e793::3.52394 > fc00:f853:ccd:e793::4.30239: Flags [S], seq 504540809, win 64800, options [mss 1440,sackOK,TS val 3651151592 ecr 0,nop,wscale 7], length 0 14:54:33.585852 cilium_host Out IP6 fc00:f853:ccd:e793::4.13607 > fd00:10:244:2::c527.80: Flags [S], seq 504540809, win 64800, options [mss 1440,sackOK,TS val 3651151592 ecr 0,nop,wscale 7], length 0 14:54:33.585856 cilium_net P IP6 fc00:f853:ccd:e793::4.13607 > fd00:10:244:2::c527.80: Flags [S], seq 504540809, win 64800, options [mss 1440,sackOK,TS val 3651151592 ecr 0,nop,wscale 7], length 0 14:54:33.585916 lo In IP6 fd00:10:244:2::c527.80 > fc00:f853:ccd:e793::4.13607: Flags [S.], seq 2619962850, ack 504540810, win 65464, options [mss 65476,sackOK,TS val 1096880080 ecr 3651151592,nop,wscale 7], length 0 14:54:33.585960 cilium_host Out IP6 fc00:f853:ccd:e793::4.13607 > fd00:10:244:2::c527.80: Flags [R], seq 504540810, win 0, length 0 The NodePort request gets SNAT-ed by iptables to the cilium_host IP addr. The trace is taken on the fc00:f853:ccd:e793::4 node which runs the selected NodePort endpoint. Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
force-pushed
the
pr/brb/revert-2005-removal
branch
from
ca7d0f1
to
8a428f1
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
Tried running the reverted revert on top of the #24208. Unfortunately the issue still persists - kube-proxy's SNAT rule (EXT NodePort) masquerades the packet to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2b58e0f.
After removing the 2005 rtable to fix the L7 issue, the kube-proxy NodePort with L7 netpol started to fail in the CI. After taking closer look, the removal of the rtable is causing the reply from the envoy proxy to be passed to lo instead of cilium_host :
14:54:33.585708 eth0 In IP6 fc00:f853:ccd:e793::3.52394 > fc00:f853:ccd:e793::4.30239: Flags [S], seq 504540809, win 64800, options [mss 1440,sackOK,TS val 3651151592 ecr 0,nop,wscale 7], length 0 14:54:33.585852 cilium_host Out IP6 fc00:f853:ccd:e793::4.13607 > fd00:10:244:2::c527.80: Flags [S], seq 504540809, win 64800, options [mss 1440,sackOK,TS val 3651151592 ecr
0,nop,wscale 7], length 0 14:54:33.585856 cilium_net P IP6
fc00:f853:ccd:e793::4.13607 > fd00:10:244:2::c527.80: Flags [S], seq 504540809,
win 64800, options [mss 1440,sackOK,TS val 3651151592 ecr 0,nop,wscale 7],
length 0 14:54:33.585916 lo In IP6 fd00:10:244:2::c527.80 >
fc00:f853:ccd:e793::4.13607: Flags [S.], seq 2619962850, ack 504540810, win
65464, options [mss 65476,sackOK,TS val 1096880080 ecr 3651151592,nop,wscale
7], length 0 14:54:33.585960 cilium_host Out IP6 fc00:f853:ccd:e793::4.13607 >
fd00:10:244:2::c527.80: Flags [R], seq 504540810, win 0, length 0
The NodePort request gets SNAT-ed by iptables to the cilium_host IP addr. The trace is taken on the fc00:f853:ccd:e793::4 node which runs the selected NodePort endpoint.
Fix #23258