-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs,daemon: Added discouragement warnings for MetalLB to docs and agent #23393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth noting the URL so users can more easily follow up?
Otherwise LGTM thanks!
4196f67
to
2f5b94a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
2f5b94a
to
d1c2d35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Reading the description, you can probably remove the |
I marked it as such since the original issue is also a release blocker and we would like this message to be there in the 1.13 docs. CC @joestringer |
/test Job 'Cilium-PR-K8s-1.24-kernel-5.4' failed: Click to show.Test Name
Failure Output
If it is a flake and a GitHub issue doesn't already exist to track it, comment Job 'Cilium-PR-K8s-1.16-kernel-4.9' failed: Click to show.Test Name
Failure Output
If it is a flake and a GitHub issue doesn't already exist to track it, comment |
Added warnings explaining that development on the MetalLB based BGP feature has stopped. The feature will not be deprecated in 1.13, so noted that security updates and bugfixes will still be applied. Even though we can't officially deprecate yet, we would like to highly discourage adoption of the old feature unless absolutely necessary. Fixes: cilium#22246 Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
d1c2d35
to
fa62dd4
Compare
Alright, its not getting better then this I guess. All reviews are in, CI green except for 2 tests which both hit flake #22019. Marking as ready-to-merge |
Added warnings explaining that development on the MetalLB based BGP feature has stopped. The feature will not be deprecated in 1.13, so noted that security updates and bugfixes will still be applied.
Even though we can't officially deprecate yet, we would like to highly discourage adoption of the old feature unless absolutely necessary.
Fixes: #22246
Signed-off-by: Dylan Reimerink dylan.reimerink@isovalent.com