Test "Remove relevant metrics series on pod deletion" #23900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using pod source/destinationContext may result in big metrics cardinality. Additionally this one component is exposing metrics for all pods running on the same k8s node. Over time with each created and removed pod number of metric data series will grow which will eventually result in slower and bigger responses on metrics endpoint and may even lead to OOM problems in cilium-agent itself or prometheus metrics collector. This change removes data series bound do certain pods when they are deleted. This is safe, because after pod deletion its metric value will never change. There is a 1 minute delay introduced between pod deletion and metric data series removal, so scrapers will have time to collect last value of given metric. Fixes: cilium#23162 Signed-off-by: Marek Chodor <mchodor@google.com>
pchaigno
added
the
release-note/misc
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just meant to try and run the Travis CI job for #23385.