pkg/envoy/xds package cleanup #24044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
|
/test |
jrajahalme
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
jrajahalme
approved these changes
Mar 9, 2023
|
/test |
|
Cilium is failing to become ready in some of the test runs, which is a bit suspicious - that suggests that there's something in this PR that is causing Cilium to crash out. The jenkins jobs and github actions should have artifacts you can download in order to investigate Cilium-agent logs to find out what's happening and how the PR changes may be influencing the failure. Alternatively you may just need to rebase the PR against the master branch. |
joestringer
added
the
dont-merge/needs-rebase
…t can be omitted Signed-off-by: tanberBro <pengfei.song@daocloud.io>
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tanberBro pengfei.song@daocloud.io
pkg/envoy/xds package remove redundant types conversion and types that can be omitted