contrib: Add support for snapshot releases #24092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update remaining scripts that don't support `-snapshot` versions. Previously the CRD schema generation step could crash out at determining the CRD schema versions for a prerelease version. This crash would be caused by attempting to find the CRD schema version on the branch corresponding to the upcoming prerelease build, but that branch didn't yet exist. Fix it by reverting to generating CRD schema only for existing branches if this is a prerelease where a branch doesn't exist yet. Signed-off-by: Joe Stringer <joe@cilium.io>
Previously we didn't pass the "previous branch" parameter to the release notes script for prereleases, which somehow ended up causing some PRs to show up in the changelog if they were merged after the previous feature freeze. In this case, figure out when there will be a minor version change and pass the prior branch into the release notes script to avoid advertising such features as coming new in snapshots or RCs. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
added
the
release-note/misc
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
joestringer
commented
Mar 1, 2023
nebril
approved these changes
Mar 3, 2023
aanm
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
The changes in this PR alone LGTM. I've left some comments in cilium/release#96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the scripts already had some 'snapshot' version/tag support already, this fixes up the remaining instances.
Used to generate #24091.